QwikDev / qwik

Instant-loading web apps, without effort
https://qwik.dev
MIT License
20.52k stars 1.27k forks source link

[✨] Switch from Eslint to Biome #6648

Open rogervila opened 2 weeks ago

rogervila commented 2 weeks ago

Is your feature request related to a problem?

This feature is unrelated to any problem but represents a significant performance improvement for the build step since Biome linter is much faster than Eslint.

Biome provides a migration tool that makes it a breeze to migrate the Eslint configuration.

Describe the solution you'd like

The solution would consist of a PR with the following changes:

Describe alternatives you've considered

AFAIK, Biome is the most performant linter on the market and, since it provides a migration tool, I have not considered other alternatives.

Additional context

Performance comparison between Eslint and Biome published on Biome's website:

eslint-vs-biome

rogervila commented 2 weeks ago

If the request gets enough support I will start the previously mentioned PR

PatrickJS commented 2 weeks ago

yes, I want to switch to Biome asap the only concerns we have are tailwind prettier plugin and qwik eslint plugin that both need to work with Biome. If there is now a path and you're willing to work with us on a PR then I don't see why not

thejackshelton commented 2 weeks ago

Hey @rogervila! This would be amazing. Biome reduces a ton of bloat and dependencies from eslint and prettier in the starters generated from the Qwik CLI, and the performance is next level.

eslint-plugin-qwik to biome is what has held us back. Would love to help out on this.

PatrickJS commented 2 weeks ago

@rogervila can you ping us in the discord so we can create a channel for this effort

thejackshelton commented 2 weeks ago

Hey @rogervila! Any status updates? Would love to help you on this effort.

shirotech commented 2 weeks ago

+1 Looking forward to this being shipped

rogervila commented 2 weeks ago

Hi @thejackshelton @shirotech I will start working on it next week together with @PatrickJS :)

maiieul commented 4 days ago

I'd absolutely love to use Biome instead of Eslint/prettier. But we'll need to make sure current users of eslint-plugin-qwik and eslint v8 aren't forced to use Biome. They might not be able to migrate if Biome isn't compatible with other tools they use.