QwikDev / qwik

Instant-loading web apps, without effort
https://qwik.dev
MIT License
20.85k stars 1.31k forks source link

chore: test fetchpriority option for link with modulepreload (DO NOT MERGE) #6832

Closed maiieul closed 2 months ago

maiieul commented 2 months ago

What is it?

Description

As discussed in https://discord.com/channels/842438759945601056/1276861655833383034/1277680025398804491

TLDR: I need this PR to test modulepreload with fetchpriority to low on qwik UI on a production setup to see if it fixes FCP and LCP issues with modulepreload.

Checklist:

changeset-bot[bot] commented 2 months ago

🦋 Changeset detected

Latest commit: 54eb131f1dce92b3dd299524e3af35f6c0233b5b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 6 packages | Name | Type | | ----------------------- | ----- | | @builder.io/qwik | Patch | | eslint-plugin-qwik | Patch | | @builder.io/qwik-city | Patch | | @builder.io/qwik-react | Patch | | @builder.io/qwik-worker | Patch | | create-qwik | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

pkg-pr-new[bot] commented 2 months ago

commit: 54eb131

npm i https://pkg.pr.new/@builder.io/qwik@6832
npm i https://pkg.pr.new/@builder.io/qwik-city@6832
npm i https://pkg.pr.new/eslint-plugin-qwik@6832
npm i https://pkg.pr.new/create-qwik@6832

Open in Stackblitz

github-actions[bot] commented 2 months ago
built with Refined Cloudflare Pages Action

âš¡ Cloudflare Pages Deployment

Name Status Preview Last Commit
qwik-docs ✅ Ready (View Log) Visit Preview fc9bc41d235953cf09f298c7136c9ec60bf017e2
maiieul commented 2 months ago

Going nowhere with this :/ Will try a different approach.