antoinepairet commented 1 month ago

What is it?

[ ] Feature / enhancement
[ ] Bug
[x] Docs / tests / types / typos
[ ] Infra

Description

sharp is a native package that requires binaries to run. Before version 0.33.0, sharp relied on a postinstall script to download binaries. This made it incompatible with early versions of bun which did not execute postinstall scripts. In the meantime, sharp relies on optionalDependencies to download the binaries. As of Bun v1.0.16, the top 500 npm packages with lifecycle scripts are allowed by default. There is no more need to add sharp in the trustedDependencies of package.json.

References:

Checklist:

[ ] My code follows the developer guidelines of this project
[x] I have performed a self-review of my own code
[ ] I have ran pnpm change and documented my changes
[x] I have made corresponding changes to the Qwik docs
[ ] Added new tests to cover the fix / functionality

changeset-bot[bot] commented 1 month ago

⚠️ No Changeset found

Latest commit: 073b73dc7ba42363444cb42f9c5f0e1da1678c99

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR