fix: add .ico to isStaticPath to prevent large 404 responses

[intellix]

What is it?

• [x] Feature / enhancement
• [ ] Bug
• [ ] Docs / tests / types / typos
• [ ] Infra

Description

When viewing any file in Chrome I noticed that it always makes a request for favicon.ico and saw that it was a 255kb pretty 404 page. I think it makes sense to include .ico as a file to regard as static.

Checklist:

• [x] My code follows the developer guidelines of this project
• [x] I have performed a self-review of my own code
• [x] I have ran pnpm change and documented my changes
• [x] I have made corresponding changes to the Qwik docs
• [x] Added new tests to cover the fix / functionality

[changeset-bot[bot]]

🦋 Changeset detected

Latest commit: 5538e844b876cfc818d9f4a6e10db3d267aca6c5

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages

| Name | Type | | --------------------- | ----- | | @builder.io/qwik-city | Patch | | eslint-plugin-qwik | Patch | | @builder.io/qwik | Patch | | create-qwik | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[pkg-pr-new[bot]]

Open in Stackblitz

npm i https://pkg.pr.new/@builder.io/qwik@6860

npm i https://pkg.pr.new/@builder.io/qwik-city@6860

npm i https://pkg.pr.new/eslint-plugin-qwik@6860

npm i https://pkg.pr.new/create-qwik@6860

commit: 0f8304d

[intellix]

Tried to use pnpm change, but no matter what I do it says no items selected etc

Edit: ok I needed to press space to select them

[github-actions[bot]]

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name	Status	Preview	Last Commit
qwik-docs	✅ Ready (View Log)	Visit Preview	0f8304df3c2cf415d9381fee702286c960b287b8

[shairez]

Thanks @intellix

Here's a tutorial I recorded about changesets - https://go.screenpal.com/watch/cZivIcVPJQV

hope it'll make things easier

[intellix]

cheers, I've fixed it. Originally I couldn't figure out how to use it cause I didn't know you had to press space bar until watching your video before. I guess I just pressed space on the next one without realising it was talking about major/minor

[wmertens]

@intellix you still marked it minor instead of patch. Anyway I edited it, no problem, just remember for next time.