QwikDev / qwik

Instant-loading web apps, without effort
https://qwik.dev
MIT License
20.87k stars 1.31k forks source link

fix(signals): computedSignal QRL handling #6907

Closed wmertens closed 2 months ago

wmertens commented 2 months ago

makes computed signals work and enforces that the calculation doesn't return a Promise (also via types)

changeset-bot[bot] commented 2 months ago

🦋 Changeset detected

Latest commit: eae2ed83b8eabb47d0ffeca0e6cc340849749955

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages | Name | Type | | --------------------- | ----- | | @builder.io/qwik | Patch | | eslint-plugin-qwik | Patch | | @builder.io/qwik-city | Patch | | create-qwik | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

pkg-pr-new[bot] commented 2 months ago

Open in Stackblitz

npm i https://pkg.pr.new/@builder.io/qwik@6907
npm i https://pkg.pr.new/@builder.io/qwik-city@6907
npm i https://pkg.pr.new/eslint-plugin-qwik@6907
npm i https://pkg.pr.new/create-qwik@6907

commit: eae2ed8

github-actions[bot] commented 2 months ago
built with Refined Cloudflare Pages Action

âš¡ Cloudflare Pages Deployment

Name Status Preview Last Commit
qwik-docs ✅ Ready (View Log) Visit Preview eae2ed83b8eabb47d0ffeca0e6cc340849749955