QwikDev / qwik

Instant-loading web apps, without effort
https://qwik.dev
MIT License
20.89k stars 1.31k forks source link

chore(qwik-auth) update dependencies due to security alert #6994

Closed tzdesign closed 1 month ago

tzdesign commented 1 month ago

the cookie package had a validation issue see https://github.com/jshttp/cookie/pull/167

changeset-bot[bot] commented 1 month ago

⚠️ No Changeset found

Latest commit: 8cc75a613027e7567e0b37907299f38669cf8966

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

pkg-pr-new[bot] commented 1 month ago

Open in Stackblitz

npm i https://pkg.pr.new/@builder.io/qwik@6994
npm i https://pkg.pr.new/@builder.io/qwik-city@6994
npm i https://pkg.pr.new/eslint-plugin-qwik@6994
npm i https://pkg.pr.new/create-qwik@6994

commit: 8cc75a6

github-actions[bot] commented 1 month ago
built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
qwik-docs ✅ Ready (View Log) Visit Preview 8cc75a613027e7567e0b37907299f38669cf8966
ianlet commented 1 month ago

Thanks for this update @tzdesign :raised_hands:

qwik-auth is deprecated and should be replaced by https://www.npmjs.com/package/@auth/qwik. So it would be better if you update your project to use this package instead. That way, you can benefit from security fixes and other patches.

tzdesign commented 1 month ago

@ianlet why don't we remove it from the monorepo?

ianlet commented 1 month ago

@tzdesign it was removed in v2. So as soon as v2 is released it won't be an issue anymore.

shairez commented 1 month ago

thanks @tzdesign

Yeah, as @ianlet said, this is package has been removed from the monorepo in V2, so closing this PR for now

If you think there's a good reason to merge this, let me know and I will