QwikDev / qwik

Instant-loading web apps, without effort
https://qwik.dev
MIT License
20.87k stars 1.31k forks source link

fix: add v2 test - should update elements correctly #7085

Open gimonaa opened 4 days ago

gimonaa commented 4 days ago

What is it?

new test to verify the proper update of the Resource component

Description

I added a new test to verify the proper update of the Resource component. When there is an input or an image inside a Resource component, it does not update correctly. However, if onPending is uncommented, the component updates as expected.

Screenshot 2024-11-22 alle 00 52 44

Screenshot 2024-11-22 alle 00 53 21

Checklist

changeset-bot[bot] commented 4 days ago

⚠️ No Changeset found

Latest commit: d2b0b64b9f4447bc6aab4453b7d3b0afe853a4af

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Varixo commented 4 days ago

Hey, are you working on a fix or just adding the failing test case?

gimonaa commented 4 days ago

Hey, are you working on a fix or just adding the failing test case?

Only test