Unexpected addresses using Range search + error with byte search

Qwokka / Cetus

Browser extension for hacking WebAssembly games a la Cheat Engine

Apache License 2.0

528 stars 45 forks source link

Unexpected addresses using Range search + error with byte search #46

Closed testitm closed 1 year ago

testitm commented 2 years ago

Hey! Sorry to bother you! I found your project very interesting and spent a lot of time debugging an online game for fun.

But I found some problems with Cetus. 1) Range search.
You can see on the screenshot, that address in search results is not bounded by Range values.

2) Byte search Also, when I tried to find some bytes, I got an error

Uncaught TypeError: Cannot read properties of undefined (reading 'count')
    at cetus.js:821:47
(anonymous) @ cetus.js:821

Maybe I didn't get something, but these two bugs make it hard to edit the certain addresses that I found in the Memory Viewer :)

testitm commented 2 years ago

Oh, the Range problem depends on the value type. So Range works as desired when I chose i8 instead of i32.

Qwokka commented 2 years ago

Hey @testitm

Thanks for catching this! I've confirmed this and I see why it's going on. Unfortunately I don't have time to fix it this evening. I'm hoping to have it fixed tomorrow.

Jack

testitm commented 2 years ago

No problem, thank you anyway :) Great tool, I will try to fix some UI problems in future, I hope :)

Qwokka commented 2 years ago

I think this is now fixed with fab16cb9908f10dc8de1a42a20a780b9d52b7b73

Please let me know if you have more issues. Thanks again for pointing this out! Jack

testitm commented 2 years ago

Hey! Found it broken https://github.com/Qwokka/Cetus/commit/fab16cb9908f10dc8de1a42a20a780b9d52b7b73#r84304655

Qwokka commented 2 years ago

Whoops, this should be fixed with de68f098b4f441575606a9582e00b687edab6e29