R-033 / toeterm

Terminal emulator for Sailfish OS, based on ThumbTerm and FingerTerm
GNU General Public License v2.0
3 stars 5 forks source link

Overlap? #6

Open TMavica opened 6 years ago

TMavica commented 6 years ago

screenshot_20180426_001 screenshot_20180426_002

TMavica commented 6 years ago

any news about?

R-033 commented 6 years ago

No progress so far, but I'm working on it

Olf0 commented 6 years ago

Well, I do not fully comprehend the issue description "Overlap?", as this is IMO the correct behaviour (of ToeTerm / ThumbTerm / FingerTerm) with Settings --> Keyboard behaviour set to its default: Fade

But in fact, setting this slider to Move in ToeTerm does not alter its virtual keyboard's behaviour, which supposedly is the bug this issue addresses.

Fixing Settings --> Keyboard behaviour --> Move (by making it working as it does in FingerTerm) would be much appreciated.

Tested with ToeTerm versions up to (and including) 1.5 under SailfishOS 2.1.4.14 on a Jolla 1 phone.

R-033 commented 6 years ago

Move is actually working as expected. It only moves content when cursor is behind keyboard The problem is that when you change orientation current active line with cursor moves in center of the screen, which is not covered by keyboard, and content is not being moved FingerTerm have same problem, and I'm trying to fix it

Olf0 commented 6 years ago

@R-033, sorry, I should have checked FingerTerm's current behaviour more thoroughly. For some reason I believed to have seen the virtual keyboard moving, which is not the case (and fine).

By comparing ToeTerm's and FingerTerm's Move behaviour in detail, I realised that you enhanced it nicely:

And thanks for the explanation, which made me comprehend what is wrong in @TMavica screenshots. I did not see the unusual cursor position in the middle of the screen and wouldn't have understood how to achieve that without an explanation. But as a CRTL-L ("Clear screen") resolves the resulting "Overlap" easily and it takes changing the orientation twice (from portrait to landscape and back to portrait) to trigger this issue in ToeTerm and FingerTerm (at least in my experiments), IMO this is a rather minor issue. Although I see, that this may happen accidentally, when using ToeTerm in portrait orientation, so a fix would be nice.

TMavica commented 6 years ago

thx Ctrl +l is best solution