Add `page_size` argument to `arc_select()`

JosiahParry commented 7 months ago

Checklist

[x] update NEWS.md
[x] documentation updated with devtools::document()
[x] devtools::check() passes locally

Changes

This PR adds a page_size argument to arc_select() which permits us to have more control over the total number of features that are returned on a per-request basis. This will allow us to overcome the issue of timeouts with dense geometries.

Closes

closes https://github.com/R-ArcGIS/arcgislayers/issues/141

Follow up tasks

Create docs on working with dense geometries. This doc will tell users how to utilize the batch_size argument to increase the number of requests made and reduce the number of features per page.

JosiahParry commented 7 months ago

Relatedly, this will let us close https://github.com/R-ArcGIS/arcgislayers/issues/138 as it gives us a working solution to the problem. It will not be automagical but it will be doable!

JosiahParry commented 7 months ago

@mmachir could you please review and test when you get a chance? To install you can run:

# get the most recent dev version of {arcgisutils} if it hasn't
#  been updated since token overhaul
pak::pak("r-arcgis/arcgisutils")

# install branch:
pak::pak("r-arcgis/arcgislayers@batch_size")

R-ArcGIS / arcgislayers