Closed JosiahParry closed 1 year ago
@mmachir would you be okay if I assigned you the task of making AGOL layers with each of the above? We would need 6 layers each with a handful of geometries (no more than 5 is really necessary).
This would be useful for building appropriate tests.
Madagascar Points handles POINT data
@JosiahParry I created an item in AGOL with layers for each of the geometry types. I don't believe there's a way to create a feature class with "envelopes"... I could create a feature class with rectangular polygons but don't think that would provide the data structure/format you're looking for.
Note: I did not include Z or M for any of these layers, let me know if that is needed.
AGOL item: Geometries
Thank you! I don't have permission to access them at the moment. Can you add to R Testing
group when you get a chance?
Wow sorry about that - forgot that basic step! It's shared to Org and R Testing now. Let me know if there are any other issues with them.
The objective of this issue is to ensure that
parse_esri_json()
parses correctly for all ppossible geometry types.The following must be implemented:
esriGeometryPoint -->
POINT
esriGeometryMultiPoint -->
MULTIPOINT
esriGeometryPolyline -->
LINESTRING
andMULTILINESTRING
esriGeometryPolygon -->
POLYGON
&MULTIPOLYGON
esriGeometryEnvelope --> arcgis class
envelope
To do this we need to have known esri json for each of the above and to write a suite of testthat tests that validate each parsing.
We also need to do this for tables (no geometry) as well as layers with no attributes