R-ArcGIS / r-bridge

Bridge library to connect ArcGIS and R, including arcgisbinding R library.
Apache License 2.0
119 stars 26 forks source link

Please remove dependencies on **rgdal**, **sp**,**rgeos**, and/or **maptools** #83

Open bchileen opened 1 year ago

bchileen commented 1 year ago

R-Spatial is moving away from rgdal, maptools, and rgeos and they will be retired in October 2023. While the arcgisbinding/r-bridge supports sf objects, the suggestion to use and support of sp functions tends to throw errors that can cause ArcPro tools to fail. The suggested solution would be to remove sp support from the arcgisbinding package to support only sf inputs and outputs.

from r-spatial: "The legacy packages maptools, rgdal, and rgeos, underpinning the sp package, which was just loaded, will retire in October 2023. Please refer to R-spatial evolution reports for details, especially https://r-spatial.org/r/2023/05/15/evolution4.html. It may be desirable to make the sf package available; package maintainers should consider adding sf to Suggests"

orhuna commented 1 year ago

@bchileen great suggestions! I will my pass this on to my colleagues at the R-ArcGIS Bridge team!

stevekopp commented 1 year ago

Hi Orhun, We just saw his post, thanks.

How’s things with the paper, were you able to submit?

Regards, Steve

From: Orhun Aydin @.> Sent: Thursday, September 7, 2023 3:20 PM To: R-ArcGIS/r-bridge @.> Cc: Subscribed @.*> Subject: Re: [R-ArcGIS/r-bridge] Please remove dependencies on rgdal, sp,rgeos, and/or maptools** (Issue #83)

@bchileen [github.com]https://urldefense.com/v3/__https:/github.com/bchileen__;!!CKZwjTOV!2CTx5uVosDlG4ZQTIORXyjeqbUfszbWSR3Xj2Bz0GygDCI9b7Ykf3L0g-xD66X9yHGkKaCpkfxAPVZBk-NyT$ great suggestions! I will my pass this on to my colleagues at the R-ArcGIS Bridge team!

— Reply to this email directly, view it on GitHub [github.com]https://urldefense.com/v3/__https:/github.com/R-ArcGIS/r-bridge/issues/83*issuecomment-1710833957__;Iw!!CKZwjTOV!2CTx5uVosDlG4ZQTIORXyjeqbUfszbWSR3Xj2Bz0GygDCI9b7Ykf3L0g-xD66X9yHGkKaCpkfxAPVQEFN-gq$, or unsubscribe [github.com]https://urldefense.com/v3/__https:/github.com/notifications/unsubscribe-auth/AC5L3R3DTSRYFYXFQE6QBTDXZJB7LANCNFSM6AAAAAA4PPXF3M__;!!CKZwjTOV!2CTx5uVosDlG4ZQTIORXyjeqbUfszbWSR3Xj2Bz0GygDCI9b7Ykf3L0g-xD66X9yHGkKaCpkfxAPVU6odCYR$. You are receiving this because you are subscribed to this thread.Message ID: @.**@.>>

JosiahParry commented 1 year ago

rgdal

Thanks @bchileen! Just to allay any concerns, there is no strong dependency on rgdal. It is a suggested package because it is used in the examples to read in raster images https://github.com/search?q=repo%3AR-ArcGIS%2Fr-bridge+rgdal&type=code

We have agreed to remedy this and we ought to push a new build next month without rgdal in the suggestion. Thank you for the reminder!

sp

As you are aware, {sp} is not being removed from CRAN but rather having its core functionality being replaced with sf. {arcgisbinding} provides a way to convert to {sp} objects. While we haven't discussed this specifically in great detail, my stance is, and I suspect some may concur—but don't hold me to that! 😉—is that we will continue to support converting to {sp} objects until sp is officially retired. The core representation of sp objects has not changed so we can still safely create those objects.

If you have reproducible examples of where using sp with {arcgisbinding} is causing a crash please open another issue detailing the steps to reproduce the error or crash.

bchileen commented 1 year ago

Thanks for the speedy follow up, I will open a new issue if the crash/freeze up continues after the new build.