Submission for assignment 4 - Githubissues

R-Jim / df-frontend-2023

https://df-frontend-2023-assignment1.vercel.app

0 stars 0 forks source link

Submission for assignment 4 #17

Open R-Jim opened 11 months ago

R-Jim commented 11 months ago

Link: https://df-frontend-2023-assignemt4.vercel.app/books

Note:

Add custom 404 page
Add light and dark mode with tailwind css
Enhance search, pagination with query params

chinhld12 commented 11 months ago

Nice work 👍

Requirements

[x] All core functionalities present
[x] Proper Tailwind implementation
[x] Book detail page
[x] 404 page
[x] Redirect after deletion
[x] Bonus: Tailwind dark/light mode
[x] Bonus: URL state sync for page and query

Result: ✅ passed

Feedback

UI appears in dark theme is not ideal
These components should be put in components folder
React children node empty render should be return a null not an empty string https://github.com/R-Jim/df-frontend-2023/blob/d9f85cdd810db4632f96bdbbc74b22653c38a825/assignment-4/src/components/page/ErrorPage.tsx#L20-L22
You should resolve for others comments on your previous Assignment 03 too