Submission for assignment 5

[R-Jim]

Link: https://df-frontend-2023-assignment5-gamma.vercel.app/

[chinhld12]

Good works 👍 ,

Requirements

• [x] All core functionalities present
• [ ] Edit form
• [x] Login page
• [x] Forms built by react-hook-form
• [x] Validation by zod
• [ ] Bonus: Password Strength Meter

Result: ✅

Feedback

Overall looks good, but have some comments for your code:

1. You can utilize this syntax for handling destructing the register props:

   -    const register = 
   -        props.register !== undefined
   -            ? props.register(props.name, props.registerOptions)
   -            : null
   +    const { register: _registerProps } = props; 
   +    const register = _registerProps?.() ?? {};
   
     // yourcode
     <select
   +       {...register} 
     ...
     />    

   https://github.com/R-Jim/df-frontend-2023/blob/d9f85cdd810db4632f96bdbbc74b22653c38a825/assignment-5/src/components/form/InputSelect.tsx#L19-L20

https://github.com/R-Jim/df-frontend-2023/blob/d9f85cdd810db4632f96bdbbc74b22653c38a825/assignment-5/src/components/form/InputText.tsx#L14-L17

...

2. I think you can create constants for each form https://github.com/R-Jim/df-frontend-2023/blob/d9f85cdd810db4632f96bdbbc74b22653c38a825/assignment-5/src/components/book/AddBookModal.tsx#L61-L101

3. Password input in login form should be used with password type

   

4. Should clear input values after created new book

5. I think you can use find method of Array instance to find the book: books.find((book) => book.id === params.id https://github.com/R-Jim/df-frontend-2023/blob/d9f85cdd810db4632f96bdbbc74b22653c38a825/assignment-5/src/app/books/%5Bid%5D/page.tsx#L19-L25