Closed mcol closed 1 month ago
I do agree with the suggested changes, thank you! And no, this NA
vs OK
mixture was not intentionally.
One additional thing: for recuperation rate we report the rejection criteria divided by 100 (line 358), but we don't divide in the actual test where we set the status (lines 369-370). For recycling ratio we divide in both places, so I expect that the same would be correct for recuperation rate too.
This means that until now recuperation rates have been marked OK in more cases than expected.
OK, obviously this also needs a fix
As part of #147, I'm having a detailed look at what
analyse_SAR.TL()
produces and returns. One of this is therejection.criteria
data frame, which is sometimes produced incorrectly.Example:
In these lines of code: https://github.com/R-Lum/Luminescence/blob/be1602b2c80944541e8386917628e9019143d1af/R/analyse_SAR.TL.R#L352-L359
RecyclingRatio
isNA
,colnames(RecyclingRatio)
isNULL
, so we get that "recuperation rate" is printed in all the rows (due to R doing recycling the non-null element in the vector): I would make it write "recycling ratio" whenRecyclingRatio
isNA
rejection.criteria
NA
is produced if noR0
dose point exists, but that's not the case, as the above data frame is generated0.1
(with a space) rather than0.1
due to thepaste("")
term+/-
could be replaced with the unicode symbol±
if desiredIn these other lines: https://github.com/R-Lum/Luminescence/blob/be1602b2c80944541e8386917628e9019143d1af/R/analyse_SAR.TL.R#L369-L370
NA
in all cases, in the "recycling ratio" cases the status isNA
, but for "recuperation rate" the status isOK
: I suppose it should beNA
in all cases, but perhaps that difference in treatment was intentional?