R-Sandor / FindFirst

Organizing the information that matters to you and your teams. The knowledge of your world.
https://findfirst.dev
Apache License 2.0
10 stars 17 forks source link

Intergrate Flyway with TestContainers #225

Closed R-Sandor closed 1 month ago

JinnJarBurger commented 1 month ago

@R-Sandor could you assign this issue to me?

R-Sandor commented 1 month ago

Awesome! Thanks @JinnJarBurger. To run integration tests you can either add this parameter on the gradlew -Dspring.profiles.active=integration

or change the server/build.gradle line 113 to this systemProperty 'spring.profiles.active', 'integration'

I turned it off temporarily because I need to be more careful on what sites I am continuously webscraping in my integration tests. I will switch back once I pick some sites that always allow with very little rate limiting.

R-Sandor commented 1 month ago

Right now I kind of use the init schema stuff for integration testing.

sever/src/main/resources/application-integration.java but that's not one to one with how my flyway works on an empty database.

JinnJarBurger commented 1 month ago

Right now I kind of use the init schema stuff for integration testing.

sever/src/main/resources/application-integration.java but that's not one to one with how my flyway works on an empty database.

Alright then, I will get started with this and let you know if I have any more queries regarding this.

JinnJarBurger commented 1 month ago

Hello @R-Sandor, just to let you know I am traveling right now and will be available again from next Tuesday, I will look into this issue after I am back if that's ok. Thanks!

R-Sandor commented 1 month ago

Hey no problem! I am not in a big rush as this doesn't break anything but I do appreciate the help so thank you.

JinnJarBurger commented 1 month ago

Hello @R-Sandor extremely sorry for the late reply, I am finally back. It looks like you have already configured a lot of the flyway configuration (including the init schemas and the gradle build file), are you planning on completing this then?

R-Sandor commented 1 month ago

@JinnJarBurger Yeah sorry about that looks like there were probably some changes over time from when this was made. I will just clean up the integration file close this ticket out!

Sorry man!

JinnJarBurger commented 1 month ago

@JinnJarBurger Yeah sorry about that looks like there were probably some changes over time from when this was made. I will just clean up the integration file close this ticket out!

Sorry man!

all good!