search

R-Sandor / FindFirst

Organizing the information that matters to you and your teams. The knowledge of your world.
https://findfirst.dev
Apache License 2.0
10 stars 17 forks source link

Create V1.0.2__add_scrapable_to_bookmark.sql #230

Closed vijay-kesanakurthi closed 1 month ago

vijay-kesanakurthi commented 1 month ago

Issue number: resolves #220 #221

R-Sandor commented 1 month ago

SQL looks good, would you mind updating the Bookmark.java entity model for the scrapable field and I will merge it in :D

vijay-kesanakurthi commented 1 month ago

Is it necessary to include a constructor for a property like screenshotUrl?

R-Sandor commented 1 month ago

That's a really good question, it should be included in the constructor with the screenshotUrl.

You'll need to update the BookmarkService.java which uses that constructor to include the new parameter for scrapable. For the time being I would default that to true. There are some frontend tickets to include that request field then we'll need to update the backend to use what the request contains, i.e. scrapable or not.

vijay-kesanakurthi commented 1 month ago

I have updated both BookmarkService and Model.

R-Sandor commented 1 month ago

@vijay-kesanakurthi Thanks! I appreciate all the help. Welcome to FindFirst!