R-Sandor / FindFirst

Organizing the information that matters to you and your teams. The knowledge of your world.
https://findfirst.dev
Apache License 2.0
10 stars 18 forks source link

feat(issue-224): update AddBkmkReq to include scrapable #238

Closed JinnJarBurger closed 1 month ago

JinnJarBurger commented 1 month ago

Issue number: #224


Checklist

What is the current behavior?

The AddBkmkReq record does not contain a boolean field named scrapable.

What is the new behavior?

The new boolean field scrapable has been added to the AddBkmkReq record, with the default value set to true as discussed in issue #223. Additionally, the BookmarkControllerTest class has been updated to ensure the tests run successfully.

Does this introduce a breaking change?

Other information

Looks like whenever I run ./gradlew spotlessApply it fails due to the DisableTenantFilter annotation class checked by the removeUnusedImports() method in the build.gradle file for the server directory. Worth looking into.

JinnJarBurger commented 1 month ago

Hello @R-Sandor, could you have a look at the PR, I also went ahead with some changes which I thought were necessary. Please let me know what you think. Thanks!