R-Sandor / FindFirst

Organizing the information that matters to you and your teams. The knowledge of your world.

https://findfirst.dev

Apache License 2.0

8 stars 8 forks source link

[Frontend] Add About Route as Public #249

Open R-Sandor opened 5 days ago

R-Sandor commented 5 days ago

Details

Currently in the security service on the frontend the findfirst.dev/about routes the user back to login. We should change that to be public.

GiannisPep commented 2 days ago

Hi, I'd like to work on this issue! I understand that the task involves changing the /about route so that it no longer redirects users to the login page and instead becomes publicly accessible. I will update the frontend security service or routing logic to ensure that authentication is not required for this specific page, while maintaining security for other protected routes. Let me know if there are any additional requirements or considerations before I proceed.

R-Sandor commented 2 days ago

@GiannisPep Absolutely, thank you!

GiannisPep commented 2 days ago

I tried to clone the repository, but I encountered an error related to an invalid path due to the file name: data/test_screenshots/https:__facebook.com.png. It seems that the file name contains characters that are not allowed on my system (Windows). Here's the error message I received:

invalid path 'data/test_screenshots/https:__facebook.com.png' unable to checkout working tree warning: Clone succeeded, but checkout failed.

R-Sandor commented 1 day ago

@GiannisPep Let me workout an alternative url scheme because in windows : is a reserved path.