search

R-Sandor / FindFirst

Organizing the information that matters to you and your teams. The knowledge of your world.
https://findfirst.dev
Apache License 2.0
10 stars 17 forks source link

Issue 226 bookmark already exist error #276

Closed Barny37 closed 4 days ago

Barny37 commented 1 week ago

Issue number: resolves #

Checklist

What is the current behavior?

For the backend, I use an already existing exception, BookmarkAlreadyExistsException, to handle cases where a bookmark already exists. This exception triggers a 409 Conflict HTTP response.

On the frontend, I catch the Conflict (409) error and use react-toastify to display a toast notification in the bottom-right corner of the screen, informing the user about the conflict that Bookmark already exist.

What is the new behavior?

-

-

Does this introduce a breaking change?

Other information

R-Sandor commented 4 days ago

Looks good but would you mind rebasing it on main? From the time when you started work to now there was a major refactor off JPA so a lot of the package and attributes changed for example: tag_title got simplified to title

Barny37 commented 4 days ago

Hi i updated my main and rebase the solution on it.

R-Sandor commented 4 days ago

Looks great! Thank you :D :rocket:

Barny37 commented 4 days ago

Thank you for having patience with me 😄