search

R-Vaccari / bannerlord-banner-kings

BSD 3-Clause "New" or "Revised" License
72 stars 1.45k forks source link

Fixes arithmetic for Magnum Opus inside BKLearningModel.CalculateLearningRate #135

Closed koddan2 closed 5 months ago

koddan2 commented 1 year ago

Adds parens so that the difference between current skill value and 230 is calculated before multiplying it with the factor.

Without the parens, the value will be calculated as such:

  1. 0.02 * skillValue
  2. then subtracting 230

instead of the, what I suppose is, the intended

  1. skillValue - 230
  2. then multiplying with 0.02
R-Vaccari commented 5 months ago

Thank you, please contact me in Discord