search

R-Vessel-X / SlicerRVXLiverSegmentation

3D Slicer plugin for Liver Anatomy Annotation by R-Vessel-X
BSD 2-Clause "Simplified" License
32 stars 7 forks source link

Update modules to use markups instead of annotations #8

Closed lassoan closed 1 year ago

lassoan commented 2 years ago

Annotations module, which provides vtkMRMLAnnotationROI and vtkMRMLAnnotationRuler nodes have been deprecated since April 2021 and will be removed in Slicer-5.4 stable version early next year. Since some modules in this extension use annotation nodes, these modules need to be updated to use markups nodes before the end of this year.

This section of the migration guide should help with implementing the changes and any questions can be asked at the Remove Annotations module topic in the Slicer forum.

Impacted modules: RVXLiverSegmentation\RVXLiverSegmentationLib\RVXLiverSegmentationLogic.py RVXLiverSegmentationEffect\RVXLiverSegmentationEffectLib\SegmentEditorEffect.py

Thibault-Pelletier commented 2 years ago

Hi @lassoan, Thank you for the heads up, I will take a look ASAP and make the necessary changes!

Thibault-Pelletier commented 1 year ago

Hi @lassoan, This issue was just adressed in the following PR : #10.

Please let me know if you see any other part of the code which may be obsolete.

lassoan commented 1 year ago

Great, thank you!