search

R-a-dio / R-a-dio-Amazing-Android-App

>wessie doesn't push to master for every commit
MIT License
11 stars 5 forks source link

on the road to 1.2 #9

Closed KilimIG closed 6 years ago

KilimIG commented 7 years ago

here's a list of what should/could be on 1.2

resttime commented 7 years ago

Part of Bluetooth tags is worked on but it's not done.

It might be necessary to move API update code from the MainActivity into the RadioService to complete the rest of it because there's no way to know when the tags change in the RadioService. Would also mean having to implement some way for the MainActivity to be notified of API update in the RadioService. Probably storing tags in the PlayerState class and then broadcasting to when the MainActivity should update. Would also mean that we would now be able to show the tags in the notification too.

I suppose it might be possible to move the code for Bluetooth tags into the MainActivity. Restricts the feature only if the MainActivity is active and simpler since it's hooking into previous functionality.

Which one?

KilimIG commented 7 years ago

the latter sounds easier and faster lol so id go with that? we'd need to poll the others to really make a decision

resttime commented 7 years ago

Kk, it's really a kind of the functionality vs complexity trade off. Though perhaps it won't be more complex, but will involve a lot more changes. I don't mind either way.

Until then and for reference: ways to do the second thing I mentioned is stuffing the PlayerState class with the tags and then sending a new intent to the RadioService. I guess alternatively one could just package the tags in the intent too.

In that case I just realized that it might be possible to have the notification updated to show tags the same way too, it'll just be restricted to work only when the MainActivity is open as well.

resttime commented 7 years ago

Screw it, went with second option. Can always be changed later. Bluetooth tags should now theoretically work.

KilimIG commented 7 years ago

oh sweet but how do we test this lol

when im home I'll pull and see if it works in my car i guess?

On Thu, Feb 2, 2017, 8:42 PM resttime notifications@github.com wrote:

Screw it, went with second option. Can always be changed later. Bluetooth tags should now theoretically work.

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/R-a-dio/R-a-dio-Amazing-Android-App/issues/9#issuecomment-277141570, or mute the thread https://github.com/notifications/unsubscribe-auth/ASe0M-dOyVqjqx43rqlz1zEFx8qaTageks5rYoYQgaJpZM4LzBZE .

KilimIG commented 7 years ago

heya rest sorry it took so long to test everything

okay so it doesnt work :-(

it just says no data provided

resttime commented 7 years ago

Pushed some changes, hopefully this works.

Kethsar commented 7 years ago

I added pages to the Search list. That took me a lot longer than I thought once I changed out the dots from a static text view to buttons to be used when they could be. Fucking hell I feel retarded.

KilimIG commented 7 years ago

alrighty bluetooth tags work perfectly fine for me, thanks rest. however can anyone else test this in their car? dunno if my device is any different

kethsar also has pagination with searches but he forgot to tell me to pull so i didn't test that out, will do when home

also any ideas for gay ricing?

resttime commented 7 years ago

Theory is strong hehehe, I'm glad it works.

As for ricing I suppose picking something from #2? I think a thing people did request was some kind of scheduling for playback for alarms? The app is becoming quite feature complete at this point so I dunno.

Albrektson commented 7 years ago

Connecting to a bluetooth reciever and starting playback with the app will leave old playback data (song name, etc.) from spotify/youtube/whatever showing on the reciever until the current song ends and a new song starts in the app.

resttime commented 7 years ago

I believe the Bluetooth issue should be simple to fix. I'm fairly pretty busy as of late so hopefully I'll get to it eventually.

resttime commented 7 years ago

Bluetooth issue fixed by @Kethsar with d8ec74eed163f9fe2eee512d7a00a816ff751876 and a49bc7df64387085f8046932ce77c062d3faeafa

Kethsar commented 6 years ago

tbh everything here that can be done has been done.