Linking to a comment in another news post doesn't work

R-a-dio / site

R/a/dio's site, open-sourced.

https://r-a-d.io

MIT License

145 stars 19 forks source link

Linking to a comment in another news post doesn't work #59

Closed rejalkarim66666 closed 10 years ago

rejalkarim66666 commented 10 years ago

It won't do anything (for example here http://r-a-d.io/news/4#220 )

ameliaikeda commented 10 years ago

Works fine unless your browser doesn't understand fragments.

rejalkarim66666 commented 10 years ago

Doesn't work in Firefox 32 (Nightly), Firefox 29, Chrome, Browser (Android) or Safari (tablet).

Links to 4#56 when it should probably be linking to 2#56.

ameliaikeda commented 10 years ago

I literally can't replicate this; it's basic browser behavior (comments have id="{{ $comment->id }}"). What are you doing beforehand?

rejalkarim66666 commented 10 years ago

http://puu.sh/8KARN.gif

Bevinsky commented 10 years ago

The problem is not that the fragments are failing, it's that the comments are not on the same news page, so the fragment doesn't link anywhere. The comment links need to determine which news post the comment is on when they are created.