search

R-a-dio / site

R/a/dio's site, open-sourced.
https://r-a-d.io
MIT License
145 stars 19 forks source link

Comments cut off at 500 letters with no error #71

Open rejalkarim66666 opened 10 years ago

rejalkarim66666 commented 10 years ago

I think it would be better if it either gave an error and/or the letter limit was higher. If not for normal users, then at least for privileged users. Currently it doesn't give any errors and just cuts off everything after 500 letters instead.

ameliaikeda commented 10 years ago

It's a database-level issue. There's nothing at all that checks this but the client-side javascript tracking letter count.

rejalkarim66666 commented 10 years ago

Normally I'd just condensed it if I hit 500, but I assumed it was different for logged in users or something (it wasn't)

(it should be)

ameliaikeda commented 10 years ago

Database column is varchar(500). I could make it text and limit to 500ish for non-logged-in users.

9001 commented 10 years ago

sounds like a good idea, varchar doesnt make much sense for non searchable text On Jul 10, 2014 3:23 AM, "Amelia" notifications@github.com wrote:

Database column is varchar(500). I could make it text and limit to 500ish for non-logged-in users.

— Reply to this email directly or view it on GitHub https://github.com/R-a-dio/site/issues/71#issuecomment-48555444.