search

R-a-dio / valkyrie

R/a/dio software stack
https://r-a-d.io
MIT License
5 stars 3 forks source link

Canonicalize song meta based on the metadata in tracks #48

Closed Bevinsky closed 5 years ago

Bevinsky commented 5 years ago

When songs are loaded, the canonical metadata is taken from the esong meta.

However, this means that no hash-agnostic changes to the meta in tracks (changing case, removing leading/trailing spaces) will affect the canonical metadata. This is a undesirable, as esong meta typically cannot be fixed, but tracks meta can be if it isn't good enough.

I suggest that, if a tracks entry exist, the formatted meta from tracks be used as the canonical metadata for that entry instead of the esong meta.

Wessie commented 5 years ago

we already do this, but added a Song.FillMetadata method in 6654e81 to make this easier to be consistent, we might want to strip whitespace in there too?