search

R-macos / recipes

System for building static dependent libraries for CRAN packages
44 stars 17 forks source link

add gmp C++ bindings #19

Closed jeffreyhanson closed 3 years ago

jeffreyhanson commented 3 years ago

I'm submitting this PR to (hopefully) add C++ bindings for the GMP library. This PR is an updated version of PR https://github.com/R-macos/recipes/pull/18. Specifically, this PR updates the GMP recipe (i.e the recipes/gmp file) to add a compilation flag that will enable these bindings (i.e. --enable-cxx). For more information on this compilation flag, please see the Build Options section of the GMP Manual (specifically "C++ Support, --enable-cxx" subsection).

To help verify that this PR works, I have created an additional branch and used GitHub Actions to verify that (1) the updated recipe in this PR provides these bindings (please see the "Verify gmpxx build" component of the build) and (2) an R package which requires these C++ bindings can be built from source using the updated recipe file (please see the "Verify package build" component of the build).

What do you think? Please let me know if there's any further changes I can make to improve this PR?

s-u commented 3 years ago

Great, thanks!

jeffreyhanson commented 3 years ago

Awesome - thank you!