search

R-nvim / R.nvim

Neovim plugin to edit R files
GNU General Public License v3.0
132 stars 15 forks source link

Remvoe the echo parameter #28

Closed PMassicotte closed 5 months ago

PMassicotte commented 5 months ago

refactor(maps.lua): remove unnecessary file_type parameter from send function refactor(maps.lua): simplify create_maps calls by removing unnecessary 'silent' and 'echo' arguments refactor(rmd.lua): remove unused 'e' parameter from send_R_chunk function refactor(rnw.lua): remove unused 'e' parameter from send_chunk function refactor(send.lua): remove unused 'e' parameter from marked_block and selection functions

I think we will have to also remove the M.get_source_args in source_file and only call it once just before sending the code to the terminal.

jalvesaq commented 5 months ago

Since "m" has only two possible values, it could be a boolean: true = move, false = stay put.

PMassicotte commented 5 months ago

I think this should do it.

PMassicotte commented 5 months ago

Realized that the send paragraph function was missing the first line of the paragraph (0 based).

jalvesaq commented 5 months ago

Thanks! In a quick test, it works. Later, we implement the max_lines_to_paste option.