search

R0tenur / visualization

MIT License
182 stars 30 forks source link

Export skips past choosing svg or md format #101

Open jcoryatjr opened 2 years ago

jcoryatjr commented 2 years ago

When exporting the ERD, after the first export each attempt following produces nothing while skipping the user's ability to choose the format.

Expected Behavior

Should work the same each time you export a schema visualization

Current Behavior

First time to export a diagram, it works as expected. Each attempt following the first will show the format selector and then open the save dialog with chart.undefined as the default name, the "Save as type:" set to "All Files (.)" and when the Save button is clicked, nothing is saved. Tried this with different databases and the same database and it is consistent behavior. The workaround is to restart ADS.

Possible Solution

Looks like it has something to do with the event handling around the export action and the logic interpreting a type has already been selected.

Steps to Reproduce

  1. Open ADS and establish connection with instance
  2. Expand leafs in server window to get to the database to export
  3. Double click on database
  4. Select the "Shema Visualization" option under General
  5. Export the schema using your choice of format
  6. Use the same database or open different and repeat steps 3-5

Context (Environment)

Exporting schemas for documentation

Detailed Description

Using version v0.8.5

Possible Implementation

R0tenur commented 2 years ago

Thank you for reporting! This is probably an duplicate of #88 and should be resolved in v0.8.5 The extension gallery is not updated so this fix is not in the version linked from data studio

jcoryatjr commented 2 years ago

I noted the version I am on is the version you mentioned. I was on an earlier version and downloaded and installed the latest from gh.

R0tenur commented 2 years ago

Then I will look into it when I get time