R0tenur / visualization

MIT License
177 stars 26 forks source link

Possible issue with non-default port use #34

Closed imavroukakis closed 3 years ago

imavroukakis commented 3 years ago

For an MSSQL server listening on any port other than the default, the plugin fails to connect to the server with the following error

Error getting data: Failed to connect to xxxx.com,14330 - getaddrinfo ENOTFOUND xxxx.com,14330

Expected Behavior

The plugin should be able to correctly parse the port number from the string.

Current Behavior

The plugin uses the entire string as a hostname resolution

Steps to Reproduce

  1. Have MSSQL listen to a non-standard port
  2. Attempt to connect analyze the schema via the plugin
imavroukakis commented 3 years ago

was using an older version of the plugin, closing!