R0tenur / visualization

MIT License
169 stars 25 forks source link

Support crazy large dbs #68

Open R0tenur opened 2 years ago

R0tenur commented 2 years ago

Mermaid is throwing "Maximum text size in diagram exceeded" to prevent completely blocking the UI when dbs are to big. The limit is already increased in #49 but could probably be increased even more if the load is put in a web worker.

bruce-dunwiddie commented 2 years ago

@R0tenur have you taken an inventory of everything that counts within this size? is it possible to review to see if there's whitespace, or long names that could be "..." suffixed in descriptions, etc? basically optimizing down exactly what data is being sent to mermaid.

R0tenur commented 2 years ago

I think the main part of the load is for calculate positions and building the svg. But since the extension is in charge of both the limit and the white space it might be possible for a couple of more users if the white space is trimmed and the limit is increased even more.

AltarBeastiful commented 2 years ago

Or support exporting the mermaid diagram text to be generated later with a high maximum text.

jguidera commented 2 years ago

Im seeing this with most of my databases. What's the resolution? I see the issue is marked as "Closed" with no resolution/

R0tenur commented 2 years ago

Im seeing this with most of my databases. What's the resolution? I see the issue is marked as "Closed" with no resolution/

There is actually support for increasing the value as big as we would like. The issue is that data studio is hanging over a certain level. I have actually an ongoing work of entierly getting rid of mermaid since it's a markdown language an not that suitable for this project.

In the meantime I have thougths of catching this error in particular and make it possible for the user to opt in to a potential hang of the application

R0tenur commented 2 years ago

@AltarBeastiful I have added support for exporting it in the most recent version, will have a real fix for the issue in a later release