search

R1KO / VIP-Core

GNU General Public License v3.0
50 stars 34 forks source link

feat(translations): add missing vip_modules.phrases.txt #109

Closed maxime1907 closed 1 year ago

maxime1907 commented 2 years ago

Sourcemod error if we dont have this file

R1KO commented 2 years ago

The error is more preferable behavior so that the user understands that he needs to download the file, and did not look for a solution why the wrong phrases are displayed.

It might be better to automatically add the latest version of this file when building the release.

I wanted to add it as a submodule, but it's only possible to add it as a folder.

maxime1907 commented 2 years ago

The error is more preferable behavior so that the user understands that he needs to download the file, and did not look for a solution why the wrong phrases are displayed.

It might be better to automatically add the latest version of this file when building the release.

I wanted to add it as a submodule, but it's only possible to add it as a folder.

Okay i understand, maybe we can find another way to deal with it like this for example:

Remove LoadTranslation of vip_modules and instead do this:

Call a forward VIP_GetFeatureTranslation so that the vip module just has to implement this function to return the translated sentence