search

R1j1t / contextualSpellCheck

✔️Contextual word checker for better suggestions
MIT License
405 stars 56 forks source link

[BUG] PyPI package missing required dependencies #55

Closed tocic closed 3 years ago

tocic commented 3 years ago

Describe the bug I can't install all the required dependencies using pip install contextualSpellCheck. It seems like PyPI package doesn't contain the fix.

To Reproduce

python -m venv venv
source venv/bin/activate
pip install contextualSpellCheck
python -c 'import contextualSpellCheck'

ModuleNotFoundError: No module named 'torch'

Expected behavior torch and other deps autoinstallation.

Version (please complete the following information): latest 0.4.0 contextualSpellCheck from PyPI.

Additional information see #17 and https://github.com/R1j1t/contextualSpellCheck/pull/18.

R1j1t commented 3 years ago

I remember removing the pytorch package from deps because I saw that contextualSpellCheck another dependency transformers already had it in its setup.

See the below line in transformers: https://github.com/huggingface/transformers/blob/b0595d33c1b1abb75fc42a54553c724154cf6cd0/setup.py#L131

I am not sure why transformers library did not trigger the pytorch download. No worries, I will add it again as part of the dependency in setup.py. Thank you for pointing out this issue! Feel free to create a PR to fix this issue. By tomorrow I will update the dependencies and release the fix to PyPI. I will also try to investigate why transformers did not trigger pytorch download.