R1j1t / contextualSpellCheck

✔️Contextual word checker for better suggestions
MIT License
405 stars 56 forks source link

[BUG] Installation fails on macOS 12.6.7 #89

Closed man00ka closed 10 months ago

man00ka commented 1 year ago

Describe the bug pip install contextualSpellCheck fails on macOS 12.6.7; M1 Pro MacBook Pro TL;DR:

editdistance/bycython.cpp:216:12: fatal error: 'longintrepr.h' file not found

I guess it's less of a bug than just the fact that it does not build for macOS 12.x yet?

To Reproduce

$ pip install contextualSpellCheck

Expected behavior Successful installation

Version (please complete the following information):

Additional information

R1j1t commented 1 year ago

Thanks for reporting this issue. It looks like a dependency editdistance installation is failing and it is a known issue. I can try the new version to check if it fixes it?

Let me know if you wanna contribute this change? We need to change below to 0.6.2! https://github.com/R1j1t/contextualSpellCheck/blob/60e48564e9f3da1b3dd1cf2974b6e0c1be07abc6/setup.py#L34

man00ka commented 1 year ago

I tried 0.6.2 and everything works fine.

I forked your repo and changed the install requirements. How should I contribute this the proper way?

Am 25.07.2023 um 02:19 schrieb Rajat @.***>:

Thanks for reporting this issue. It looks like a dependency editdistance installation is failing and it is a known issue https://github.com/roy-ht/editdistance/issues/94. I can try the new version to check if it fixes it?

Let me know if you wanna contribute this change? We need to change below to 0.6.2! https://github.com/R1j1t/contextualSpellCheck/blob/60e48564e9f3da1b3dd1cf2974b6e0c1be07abc6/setup.py#L34 https://github.com/R1j1t/contextualSpellCheck/blob/60e48564e9f3da1b3dd1cf2974b6e0c1be07abc6/setup.py#L34 — Reply to this email directly, view it on GitHub https://github.com/R1j1t/contextualSpellCheck/issues/89#issuecomment-1648790240, or unsubscribe https://github.com/notifications/unsubscribe-auth/ASVQVDDFSD2XW5EHZMWUOMDXR4GKXANCNFSM6AAAAAA2NJKBHA. You are receiving this because you authored the thread.

R1j1t commented 1 year ago

Sounds great! Could you please create a PR so that I can test and merge!

Thanks @adkiem for checking the new dependency version!

albydeca commented 10 months ago

Hey! Thanks for fixing this. Any chance it can be included in a new pyPI release?

R1j1t commented 10 months ago

I was waiting for another PR to merge as well, but I can release a patch by tomorrow.

albydeca commented 10 months ago

Up to you :)

R1j1t commented 10 months ago

Path released! Thanks @adkiem for your contribution. Feel free to add other features, I would be glad to incorporate them.

Cheers!