search

R2Northstar / Atlas

The next-gen master server for Northstar.
MIT License
21 stars 8 forks source link

Split minimum launcher version by client/server #28

Closed pg9182 closed 1 year ago

pg9182 commented 1 year ago

Remains backwards-compatible with old configuration. No changes to the metrics since we can already differentiate version gate failures by request endpoint.

Closes #27

pg9182 commented 1 year ago

no reason to maintain compatibility with old config file unless you see a specific need for it

Backwards compatibility is good to have, common in Go projects, and doesn't cost much to maintain: https://github.com/R2Northstar/Atlas/blob/833b535eb4a5da8100c43c91ac21eb0f6d867404/pkg/atlas/server.go#L283-L290.

GeckoEidechse commented 1 year ago

Backwards compatibility is good to have, common in Go projects, and doesn't cost much to maintain:

I'll leave the decision up to you then. Given that the repo has a single users, i.e. us, I personally don't see a need to keep backwards compatibility but in the end it's you who has to deal with maintaining codebase :P

pg9182 commented 1 year ago

don't see a need to keep backwards compatibility but in the end it's you who has to deal with maintaining codebase

Also me who does deployments, which are much safer and easier if I don't have to synchronize binary upgrades and config file changes.