search

R2Northstar / Northstar

Repo for packaged Northstar releases
https://northstar.tf/
MIT License
1.69k stars 129 forks source link

Sometimes, players can't join anymore after a disconnection #450

Closed Legonzaur closed 1 year ago

Legonzaur commented 1 year ago

Bug

Sometimes, after disconnecting or being disconnected, players encounter an issue where they can't rejoin the server anymore. The error players see is Connection to server timed out whenever they try to join the server they got disconnected from. Joining other servers works fine. Restarting the client doesn't solves this issue.

This issue can last from 20 minutes to around 1 hour. Afterwards, the player can rejoin the server again

image

More details

This issue started to arise when Fvnkhead updated his servers to 1.12.4. When I talked about it on Discord, it seemed that some other servers are also concerned, in particular Neinguar's servers.

While this can happen after being kicked out with the message Disconnect: Sent too many stringcmd commands. from #448, this can also happen when retrying to disconnect and reconnect from the server because of #449

I had some results trying to continue to play by switching between 4G and ADSL whenever the server didn't wanted me to join again, until I ultimately was unable to join with both internet connections.

GeckoEidechse commented 1 year ago

Wait so getting disconnected from a server due to Disconnect: Sent too many stringcmd commands. completely prevents you from rejoining for extended periods? o_O

I would expect that due to the circumstance of the disconnect, one would be unable to rejoin until fully timed out on the server but that should be like 1 minute top, not 20+. Could be that it coincides with map change...? Hmm....

NoCatt commented 1 year ago

2 confirmed cases where the users had the v1.12.4 version on client with v1.12.4 on server, the issues seems to be fixed at random. ( players were playing with no mods )

ASpoonPlaysGames commented 1 year ago

Sounds to me like the server is making client send a number of stringcmds on connect, and that number is increasing somehow? Map change sounds like the reason for it stopping though.

I have a suspicion, I'll look into it properly in a bit

Legonzaur commented 1 year ago

Wait so getting disconnected from a server due to Disconnect: Sent too many stringcmd commands. completely prevents you from rejoining for extended periods? o_O

I would expect that due to the circumstance of the disconnect, one would be unable to rejoin until fully timed out on the server but that should be like 1 minute top, not 20+. Could be that it coincides with map change...? Hmm....

This issue in particular can also happen after manually disconnecting from the server

Legonzaur commented 1 year ago

As far as I tested, this doesn't occurs in 1.12.3. Only 1.12.4

GeckoEidechse commented 1 year ago

As far as I tested, this doesn't occurs in 1.12.3. Only 1.12.4

Huh, ngl I didn't expect. If you don't mind, running v1.12.3 over the weekend and checking for player feedback could help a lot in debugging this issue :eyes:

Legonzaur commented 1 year ago

Problem resolved after #447 and/or v1.12.5