search

R2Northstar / Northstar

Repo for packaged Northstar releases
https://northstar.tf/
MIT License
1.69k stars 129 forks source link

Ions Vortex shield flashes and makes the equip sound each time user shoots with full energy #569

Open EM4Volts opened 1 year ago

EM4Volts commented 1 year ago

Bug

Ions Vortex shield flashes and makes the equip sound each time user shoots with full energy

Steps to reproduce

1.have full energy as iion 2.shoot

Specifications

https://cdn.discordapp.com/attachments/925541687923707904/1163072205492584508/Unbenanntes_Video_Mit_Clipchamp_erstellt.mp4?ex=653e3e66&is=652bc966&hm=c351d5d1ef07f275525230046926368afa0a14affd844b008e45adaf21583a62&

EM4Volts commented 1 year ago

happens will only core mods enabled btw. not some rogue mod

ASpoonPlaysGames commented 1 year ago

Which ion kit do you have equipped?

EM4Volts commented 1 year ago

Which ion kit do you have equipped?

i had entangled energy, someone else used refraction lense. same result the core functionality is borked

ASpoonPlaysGames commented 1 year ago

Very strange, I'll take a look now

ASpoonPlaysGames commented 1 year ago

This happens in vanilla as well, seems to be a client prediction issue. not sure what to do about it

EM4Volts commented 1 year ago

This happens in vanilla as well, seems to be a client prediction issue. not sure what to do about it

strange, i wouldve thought its not on vanilla since people wouldve noticed and respawn wouldve patched it but i guessed wrong.

my guess is that when u shoot u still use up some energy that gets regenerated each time. so for like a small fraction of a second the energy is not 100% making the shield not full thus making the recharge effect when the enrgy is recharged instantly

ASpoonPlaysGames commented 1 year ago

my guess is that when u shoot u still use up some energy that gets regenerated each time. so for like a small fraction of a second the energy is not 100% making the shield not full thus making the recharge effect when the enrgy is recharged instantly

Close.

What happens is that client side predicts some energy loss (for some reason) and server says no energy loss, so the bar flickers back and forth, causing the rui to think that it just recharged. This is actually more consistent in vanilla, due to ping. If you are running on a lower framerate, you wont render a frame between the incorrect client prediction and server result on a listen server.

You can see the cause more by watching the bar when you aren't full on energy

EM4Volts commented 1 year ago

my guess is that when u shoot u still use up some energy that gets regenerated each time. so for like a small fraction of a second the energy is not 100% making the shield not full thus making the recharge effect when the enrgy is recharged instantly

Close.

What happens is that client side predicts some energy loss (for some reason) and server says no energy loss, so the bar flickers back and forth, causing the rui to think that it just recharged. This is actually more consistent in vanilla, due to ping. If you are running on a lower framerate, you wont render a frame between the incorrect client prediction and server result on a listen server.

You can see the cause more by watching the bar when you aren't full on energy

idea for solution: limit the shield to 99.9% energy so the popup cant happen

ASpoonPlaysGames commented 1 year ago

idea for solution: limit the shield to 99.9% energy so the popup cant happen

Alternatively fix the bit in client code that is going wrong and causing an incorrect prediction

ASpoonPlaysGames commented 1 year ago

Ok yeah, doesn't seem to be something that can be fixed in script, best we can get is the opposite effect (flickering when using split shot)