search

R2Northstar / NorthstarLauncher

Launcher used to modify Titanfall 2 to allow mods to be loaded
MIT License
281 stars 126 forks source link

Crash removing `runtime/compiled` folder #547

Open ASpoonPlaysGames opened 1 year ago

ASpoonPlaysGames commented 1 year ago

Crash log from user in Discord:

nslog2023-09-12_21-48-53.txt

Seems to be caused by this code? https://github.com/R2Northstar/NorthstarLauncher/blob/07e76e3a8e2738dbb7a1d5a6aeaa908a838f5a02/NorthstarDLL/mods/modmanager.cpp#L589

Solution to the problem was to delete the folder manually, although this is a temporary fix I would assume.

uniboi commented 1 year ago

"remove_all: Zugriff verweigert: "R2Northstar\runtime\compiled"

The launcher doesn't have the necessary permissions to delete the folder for some reason

ASpoonPlaysGames commented 1 year ago

The launcher doesn't have the necessary permissions to delete the folder for some reason

That seems to be the case, yeah. We definitely shouldn't crash like this though, should probably display an error dialog or something explaining the issue? (Or we could try and handle the exception nicely but I doubt that that is possible given the error)

uniboi commented 1 year ago

Yeah a windows message box would probably be enough. How does this even happen though

ASpoonPlaysGames commented 1 year ago

I honestly have no idea. Perhaps just a read-only folder thing for some reason? perhaps they installed the game into a read-only folder and then marked most of it as not read-only, but missed this folder somehow? idk