Don't build when format check failed

R2Northstar / NorthstarLauncher

Launcher used to modify Titanfall 2 to allow mods to be loaded

MIT License

279 stars 127 forks source link

Don't build when format check failed #720

Closed Jan200101 closed 3 months ago

Jan200101 commented 3 months ago

This will prevent needless CI running when the format is all wack

GeckoEidechse commented 3 months ago

This is kinda on purpose so that we can easily test PR builds even if PR author managed to mess up formatting.

I'm fine with changing it though if desired ^^

Jan200101 commented 3 months ago

I guess? but considering the nature of a pull request, it should have the right format already. Idk, leaving this up to someone else to decide.

Alystrasz commented 3 months ago

I agree with this change, let's not encourage authors not to format their code!

GeckoEidechse commented 3 months ago

Just to be clear, PRs are already blocked from being merged until they are properly formatted. This change would just block PRs from being tested while they are still improperly formatted ^^