Replace `NOTE_UNUSED` with standard `[[maybe_unused]]` attribute

R2Northstar / NorthstarLauncher

Launcher used to modify Titanfall 2 to allow mods to be loaded

MIT License

279 stars 127 forks source link

Closed Jan200101 closed 3 months ago

Jan200101 commented 3 months ago

Replaces the NOTE_UNUSED macro with the standardized [[maybe_unused]] attribute.

GeckoEidechse commented 3 months ago

Tagging @ASpoonPlaysGames who introduced NOTE_UNUSED(). This might be of interest to you. I only learned about this with this PR too :eyes:

Jan200101 commented 3 months ago

this is nothing more than NOTE_UNUSED but as an attribute instead of within the code to give the compiler a hint.

ASpoonPlaysGames commented 3 months ago

Functionally, yes. But using the standard attribute means that we should really follow best practice with it