search

R2Northstar / NorthstarMasterServer

Master server for Northstar
MIT License
92 stars 33 forks source link

Encode usernames so that they are valid URI strings #70

Closed ASpoonPlaysGames closed 2 years ago

ASpoonPlaysGames commented 2 years ago

Some users were failing auth due to their name not being a valid URI string, namely "Gromit " (6 spaces) ended up being shortened to "Gromit" and therefore was failing auth

This could use some testing, idk how to test this particular case properly tbh

GeckoEidechse commented 2 years ago

Huh, so I've seen them playing on Northstar a few weeks before so I'm wondering what we changed that caused it to break for them ^^

@barnabwhy any ideas? Wanna take a look at the PR? <3

barnabwhy commented 2 years ago

Talking to Spoon on the discord about this right now. We assume that there's some error in the request that goes to gameservers from masterserver if there are spaces in the username

ASpoonPlaysGames commented 2 years ago

https://github.com/R2Northstar/NorthstarMasterServer/commit/737c637c9f4e9708eab3d8430a908dd5e549d689 looks like this commit is what changed it, but it seems the masterserver itself wasnt updated until recently? (Gromit says it stopped working on the 3rd, so maybe the 1.7.0 update and they just didn't play until the 3rd or something?)

barnabwhy commented 2 years ago

https://github.com/R2Northstar/NorthstarMasterServer/commit/737c637c9f4e9708eab3d8430a908dd5e549d689 looks like this commit is what changed it, but it seems the masterserver itself wasnt updated until recently? (Gromit says it stopped working on the 3rd, so maybe the 1.7.0 update and they just didn't play until the 3rd or something?)

Yeah ms wasn't updated until recently. We got the origin stuff working around the 3rd