search

R2Northstar / NorthstarMasterServer

Master server for Northstar
MIT License
92 stars 33 forks source link

Added Dockerfile #73

Closed anjannair closed 2 years ago

anjannair commented 2 years ago

This PR should fix #71

anjannair commented 2 years ago

Could you add a .dockerignore file containing .git and the contents of .gitignore so unnecessary files aren't copied to the image, and to prevent node_modules from conflicting if it's in a dirty checkout?

Done too!

anjannair commented 2 years ago

@pg9182 I have noticed using node:16.15.0-alpine instead of node:16.15.0 reduces the final image size from 965MB to 170MB without any performance issues Should I change that accordingly or should I let it be how it is?

pg9182 commented 2 years ago

Yeah, do that. I usually use alpine-based images myself.

anjannair commented 2 years ago

@pg9182 done!

GeckoEidechse commented 2 years ago

Also works with podman in testing.