search

R2Northstar / NorthstarWiki

Wiki covering installation, hosting and configuration of Northstar
https://r2northstar.gitbook.io/
MIT License
34 stars 54 forks source link

Tell the user to install Proton-GE instead of northstarproton #244

Closed ilovethensa closed 1 year ago

ilovethensa commented 1 year ago

Now that Proton-GE has supported northstar for quite some time now, we should tell the users to install Proton-GE instead of northstarproton as it has not been updated in a while anyway

EM4Volts commented 1 year ago

northstar proton literally got an update 2 days ago

https://github.com/R2NorthstarTools/NorthstarProton/releases/tag/v8-20

instead of removing this id suggest having it mention that protonGE also works, since northstarproton is more specialized for northstar removing it would just be an L

cyrv6737 commented 1 year ago

Maintainer of NorthstarProton here.

No.

Our history with running Northstar on linux in general, especially on Proton, has been pretty rough. NorthstarProton serves as a stable and SUPPORTED runner that we can make sure Northstar runs on. We have absolutely no control over what goes on at proton-ge-custom (and nor should we). Until we:

  1. Have faith in Valve's proton base enough that we feel we can support generic runners
  2. LatencyFleX is included in upstream proton-ge-custom

we have absolutely no business recommending GE over NorthstarProton. The latest NorthstarProton release is literally based on GE-Proton8-20.

If you want to use GE instead, go for it, but this PR should not be merged.

I do however agree with @EM4Volts that a note somewhere about GE being known to work would be good as long as we also note that it is unsupported officially.

ilovethensa commented 1 year ago

I think it should atleast be mentioned that it can be used, but if you guys dont want it merged i wont press any further, you can close this if you want

KyleGospo commented 1 year ago

I think it should atleast be mentioned that it can be used

No. When it breaks we'll have endless support requests that could have been fixed by just updating Northstar proton.

ilovethensa commented 1 year ago

K then, sorry for the issue then

EM4Volts commented 1 year ago

K then, sorry for the issue then

no need to be sorry, also please in the future try to keep ur branch names to be somewhat relevant to the content. for this for example you couldve named ur branch "protonge_switch" something like that that is relevant, not something like "patch-1" just a small tidbit but some people here want to keep it clean

ilovethensa commented 1 year ago

ty, this was actually one of my first(or attempting to make) contributions

GeckoEidechse commented 1 year ago

ty, this was actually one of my first(or attempting to make) contributions

And hopefully far from the last ;) If you have any question or like please do not hesitate to reach out <3