search

R2NorthstarTools / FlightCore

Installer/Updater/Launcher for Northstar
MIT License
63 stars 14 forks source link

Investigate Windows CI builds failing #280

Closed GeckoEidechse closed 1 year ago

GeckoEidechse commented 1 year ago

https://github.com/R2NorthstarTools/FlightCore/commit/675d75d817d4279b7a8630700d1feb691e4a7e31#commitcomment-109860468

GeckoEidechse commented 1 year ago

Actually I think the reason for failing builds is that Rust 1.69 was just released and our CI currently always pulls in newest stable.

When compiling on Windows locally with 1.68 it still compiles but throws a warning with

warning: the following packages contain code that will be rejected by a future version of Rust: nom v1.2.4, ntapi v0.3.7

which I guess is now rejected code ^^

GeckoEidechse commented 1 year ago

game-scanner seems to be the crate pulling in the outdated version of ntapi. Issue is it hasn't seen an update in a while so we might have to just drop it entirely.

GeckoEidechse commented 1 year ago

I opened an issue with game-scanner upstream but depending on the time until response we might wanna consider dropping it.

It's only used for a single task atm which is getting Titanfall2 install location on Origin/EA-App and for that we could just write our own logic (which would also reduce number of dependencies used).

GeckoEidechse commented 1 year ago

Closed as completed by #281