search

R2NorthstarTools / FlightCore

Installer/Updater/Launcher for Northstar
MIT License
63 stars 14 forks source link

Add functionality to show readme of thunderstore mods inside flightcore #551

Open EM4Volts opened 1 year ago

EM4Volts commented 1 year ago

Currently flightcore opens the browser for a user to show the readme, which is inconvenient. instead have a window open in flightcore that shows the readme so no webbrowser needs to be opened each time.

Alystrasz commented 1 year ago

afaik Viper has this behaviour, and showed Thunderstore ad banners as well (which I didn't see in my browser).

EM4Volts commented 1 year ago

afaik Viper has this behaviour, and showed Thunderstore ad banners as well (which I didn't see in my browser).

pretty sure viper just opens a small webview window of the readme then instead of just parsing it and showing it in a fancy window.

0neGal commented 1 year ago

Randomly caught onto this issue, and just to elaborate, Viper does indeed just show a webview of the mod's page, along with some custom CSS. I would've liked to parse the README instead, but from what I can tell, there's no API to get the raw version of that.

And to make sure nothing randomly breaks just because changes in the HTML occur or similar, I opted for simply showing the page.

As for the ads, they're only there because it kind of feels wrong to omit them, especially given I have no permission to do as such, were I to get permission from someone involved with Thunderstore, then I could easily remove them.