search

R3-Archive / cordapp-example

This repository is deprecated. The latest version of all the official CorDapp samples can be found in the official samples repository: https://github.com/corda/samples.
Other
77 stars 118 forks source link

Don't Use the Config Dev Source Sets For Log4J #132

Open opticyclic opened 6 years ago

opticyclic commented 6 years ago

In this project and loads of other examples you create a source set that is used by multiple modules. https://github.com/corda/cordapp-example/blob/release-V3/kotlin-source/build.gradle#L17-L27

There are several better ways to inherit a log4j config.

One of which has been fixed in corda core.

joeldudley commented 6 years ago

@opticyclic Can you open a PR to fix this? See https://docs.corda.net/contributing.html for guidelines.