search

R3BRootGroup / R3BRoot

Framework for Simulations and Data Analysis of R3B Experiment
https://github.com/R3BRootGroup/R3BRoot/wiki
GNU General Public License v3.0
18 stars 102 forks source link

add comments in R3BMusliMapped2Cal #1007

Closed audreychatillon closed 7 months ago

audreychatillon commented 7 months ago

clang-format

change some variable names to get difference between time and drift time

Describe your proposal.

Mention any issue this PR is resolved or is related to.

Checklist:

ryotani commented 7 months ago

Hi just a quick question. Did you plan to use musli firmware for the experiments in February? We're thinking of making online spectra classes and wondering if we should use musli or twim classes.

audreychatillon commented 7 months ago

with light ions we should use musli firmware. In principle, a lot (parameters and online) was already developed for the Anna and Olivier experiments in 2022. I am looking at the code now and try to add few comments.

Le ven. 2 févr. 2024 à 17:49, Ryo Taniuchi @.***> a écrit :

Hi just a quick question. Did you plan to use musli firmware for the experiments in February? We're thinking of making online spectra classes and wondering if we should use musli or twim classes.

— Reply to this email directly, view it on GitHub https://github.com/R3BRootGroup/R3BRoot/pull/1007#issuecomment-1924257820, or unsubscribe https://github.com/notifications/unsubscribe-auth/AGM65JESJTFM54Z2DF3NHJTYRUKJ3AVCNFSM6AAAAABCW5UWZGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMRUGI2TOOBSGA . You are receiving this because you authored the thread.Message ID: @.***>

audreychatillon commented 7 months ago

I have already prepared the FrsSci versus Musli I am not sure this is really useful finally. For Marina experiment, there is no FrsSci at Cave C. So the AoQ should be done using LOS as stop.

@Ryo Taniuchi @.***> if you want to check the code, to see what is already available. Maybe for Marina experiment, we will need to use sci2, los and musli. In that case, we will have to modify the mapping in upexps. The latter should anyhow been modified, since there is not the same number of of scintiallators between s118 and s091

Le ven. 2 févr. 2024 à 17:54, Audrey @.***> a écrit :

with light ions we should use musli firmware. In principle, a lot (parameters and online) was already developed for the Anna and Olivier experiments in 2022. I am looking at the code now and try to add few comments.

Le ven. 2 févr. 2024 à 17:49, Ryo Taniuchi @.***> a écrit :

Hi just a quick question. Did you plan to use musli firmware for the experiments in February? We're thinking of making online spectra classes and wondering if we should use musli or twim classes.

— Reply to this email directly, view it on GitHub https://github.com/R3BRootGroup/R3BRoot/pull/1007#issuecomment-1924257820, or unsubscribe https://github.com/notifications/unsubscribe-auth/AGM65JESJTFM54Z2DF3NHJTYRUKJ3AVCNFSM6AAAAABCW5UWZGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMRUGI2TOOBSGA . You are receiving this because you authored the thread.Message ID: @.***>

audreychatillon commented 7 months ago

at least it will be useful for C beam at the begining of the Roman´s experiment, while tuning the FRS.

Le ven. 2 févr. 2024 à 18:04, Audrey @.***> a écrit :

I have already prepared the FrsSci versus Musli I am not sure this is really useful finally. For Marina experiment, there is no FrsSci at Cave C. So the AoQ should be done using LOS as stop.

@Ryo Taniuchi @.***> if you want to check the code, to see what is already available. Maybe for Marina experiment, we will need to use sci2, los and musli. In that case, we will have to modify the mapping in upexps. The latter should anyhow been modified, since there is not the same number of of scintiallators between s118 and s091

Le ven. 2 févr. 2024 à 17:54, Audrey @.***> a écrit :

with light ions we should use musli firmware. In principle, a lot (parameters and online) was already developed for the Anna and Olivier experiments in 2022. I am looking at the code now and try to add few comments.

Le ven. 2 févr. 2024 à 17:49, Ryo Taniuchi @.***> a écrit :

Hi just a quick question. Did you plan to use musli firmware for the experiments in February? We're thinking of making online spectra classes and wondering if we should use musli or twim classes.

— Reply to this email directly, view it on GitHub https://github.com/R3BRootGroup/R3BRoot/pull/1007#issuecomment-1924257820, or unsubscribe https://github.com/notifications/unsubscribe-auth/AGM65JESJTFM54Z2DF3NHJTYRUKJ3AVCNFSM6AAAAABCW5UWZGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMRUGI2TOOBSGA . You are receiving this because you authored the thread.Message ID: @.***>

jose-luis-rs commented 7 months ago

We can add LOS later, can I merge this?

audreychatillon commented 7 months ago

for me, yes !

Le ven. 2 févr. 2024, 19:33, Jose Luis Rodriguez @.***> a écrit :

We can add LOS later, can I merge this?

— Reply to this email directly, view it on GitHub https://github.com/R3BRootGroup/R3BRoot/pull/1007#issuecomment-1924463436, or unsubscribe https://github.com/notifications/unsubscribe-auth/AGM65JBSMGCMNZRYMIEPW23YRUWRLAVCNFSM6AAAAABCW5UWZGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMRUGQ3DGNBTGY . You are receiving this because you authored the thread.Message ID: @.***>