Fix frs & asyeos cmake errors

R3BRootGroup / R3BRoot

Framework for Simulations and Data Analysis of R3B Experiment

https://github.com/R3BRootGroup/R3BRoot/wiki

GNU General Public License v3.0

18 stars 102 forks source link

Fix frs & asyeos cmake errors #1072

Closed YanzhaoW closed 1 month ago

YanzhaoW commented 1 month ago

Adapt FRS repository to CMake targets.

Checklist:

[x] Rebased against dev branch
[x] My name is in the resp. CONTRIBUTORS/AUTHORS file
[x] Followed the pull request guidlines and the Git workflow
[x] Followed the seven rules of great commit messages

YanzhaoW commented 1 month ago

Hi @jose-luis-rs

I submit a PR in frs repo and it's required to pass the CI of this PR.

YanzhaoW commented 1 month ago

For the next time when both R3BRoot and subprojects needed to be changed, I think it's better to merge the PRs in the subprojects first and make sure the CIs are passed here before its merging.

jose-luis-rs commented 1 month ago

Thanks @YanzhaoW Now the code compiles with all the subprojects under FairRoot19.0.0, but it still fails with previous versions.

YanzhaoW commented 1 month ago

Ok, I will fix that in this PR.

YanzhaoW commented 1 month ago

Hi, @jose-luis-rs

All tests in our CI (which uses FairRoot 18.8) passed. Are there any errors from your side?

jose-luis-rs commented 1 month ago

Many thanks @YanzhaoW