R3BRootGroup / R3BRoot

Framework for Simulations and Data Analysis of R3B Experiment
https://github.com/R3BRootGroup/R3BRoot/wiki
GNU General Public License v3.0
18 stars 104 forks source link

[HOT FIX] Bug fixing in Neuland digitisation simulation #888

Closed YanzhaoW closed 1 year ago

YanzhaoW commented 1 year ago

Thanks to @ivanalihtar and Nikhil, some bugs were found in the new NeuLAND digitizer classes.

Here are the changes to fix those bugs:

  1. Make the global hit parameter non-const if user needs to read the parameter from a root file.
  2. Add an option of runID in neulandSim executable such that the runID could have the same value as in the parameter root file.
  3. Add additional information in the manual, explicitly saying the runIDs must be the same in both simulation file and parameter file.
  4. Fix the mistake made in the distance calculation. Originally, the reconstructed signal distance is the negative of its original predefined value. For example, if a hit at position of 1 m is added to the paddle, the result of its corresponding signal has a position of -1 m.
  5. Add an additional googletest for the distance checking, such that such mistake won't happen again.

Feel free to comment below.

Checklist:

YanzhaoW commented 1 year ago

@jose-luis-rs Ready to be merged.