R3BRootGroup / R3BRoot

Framework for Simulations and Data Analysis of R3B Experiment
https://github.com/R3BRootGroup/R3BRoot/wiki
GNU General Public License v3.0
18 stars 103 forks source link

Updated classes for s091/s118 part1 #961

Closed ManuelXarepe closed 9 months ago

ManuelXarepe commented 9 months ago

Describe your proposal.

Part 1 of the RPC classes update for upcoming experiments. Fixed a bug in mapped to precal.


Checklist:

jose-luis-rs commented 9 months ago

The definition of canvas is also inverted, you have for instance: stripCalTimeCorrCanvas = new TCanvas("Left Time Vs Right Time", "leftTimeVsRightTime");

but it should be: stripCalTimeCorrCanvas = new TCanvas("leftTimeVsRightTime", "Left Time Vs Right Time"); ---> new_canvas = new TCanvas("Name", "Title");

jose-luis-rs commented 9 months ago

You could also use: R3B::root_owned<TH2F> ; R3B::root_owned<TH1F> , ..... instead of "new TH2F" ; "new TH1F" , .....

ManuelXarepe commented 9 months ago

I have seen the problem with the online, this is because you have "spaces" in the name definition for all TFolder, TCanvas and histograms. Just introduce _ to solve the problem. Example: sprintf(name, "Left : Coarse Time Strip_%i", i + 1); stripCoarseLeftHisto[i] = new TH1F(name, name, 200, 0, 2200); ----> sprintf(name, "Left:Coarse_TimeStrip%i", i + 1); stripCoarseLeftHisto[i] = new TH1F(name, name, 200, 0, 2200);

Thank you for the help! I implemented this and changed TH1F and TH2F to r3b_owned... Now we see the cal level plots. The number of lines changed skyrocketed but most of these are histogram names being changed, I believe it should be a easy review.